Add mutex to KernelMap Cache #382
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
…lane-lightning into add_mutex_getkernelmap
Codecov Report
@@ Coverage Diff @@
## master #382 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 49 49
Lines 4458 4471 +13
=======================================
+ Hits 4453 4466 +13
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
chaeyeunpark
requested review from
mlxd,
maliasadi and
AmintorDusko
and removed request for
maliasadi
mlxd
reviewed
Nov 1, 2022
There was a problem hiding this comment.
Thanks @chaeyeunpark
Looks good, but just a few queries before approving.
AmintorDusko
approved these changes
Nov 2, 2022
|
Please wait for PR #383 to be merged before merging this PR. |
|
Thanks all for cool reviews! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: KernelMap class provides the best kernel to use based on [number of qubits], [threading], and memory alignment. To generate the kernel information quickly, it uses an internal cache mechanism. However, this violated const correctness and raised a multithreading bug. This PR fixes this bug.
Description of the Change:
Benefits:
Possible Drawbacks:
Related GitHub Issues: