-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve installation supports with external builds #403
Conversation
Hello. You may have forgotten to update the changelog!
|
…ne-lightning into update_cmake_install
…ne-lightning into update_cmake_install
Codecov Report
@@ Coverage Diff @@
## master #403 +/- ##
=======================================
Coverage 99.88% 99.88%
=======================================
Files 49 49
Lines 4463 4463
=======================================
Hits 4458 4458
Misses 5 5
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
First iteration. Looks good so far.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @mlxd for the nice work and looks nice for me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work so far!
Hi @mlxd, looks good to me. I'm wondering, why did the benchmarks and tests got renamed with the |
Thanks @vincentmr. With this update, we have the option to install the built binaries into a given prefix path from CMake, and for our updates to support spack. If we installed our test runner (previously named |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for that!
Hey @mlxd, black just released its new version. Before merging, please update black locally and run: |
Done. Will merge after the CI passes |
2 similar comments
Done. Will merge after the CI passes |
Done. Will merge after the CI passes |
Context: The CMake build system, and associated targets, do not fully conform to a CMake installation step. As such, to allow better reproducibility across builds, and integration with platforms such as spack, we need to make some adjustments to best support this.
Description of the Change: Change benchmark and test target names, macro variable usage and header visibility. Running
cmake --install ./build
following a compilation step will now install the headers and compiled binaries into a predefined target location withbin
include
andlib
directories.Benefits: Enables better support for installation of lightning targets, headers, and spack integration.
Possible Drawbacks:
Related GitHub Issues: