Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MPI compat workflows. #536

Merged
merged 17 commits into from
Oct 31, 2023
Merged

Add MPI compat workflows. #536

merged 17 commits into from
Oct 31, 2023

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Oct 30, 2023

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
MPI tests for L-GPU are missing from the compatibility workflows.

Description of the Change:
Add MPI tests in the compatibility workflows.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

@codecov
Copy link

codecov bot commented Oct 30, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (ce8597e) 99.00% compared to head (902b349) 99.20%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #536      +/-   ##
==========================================
+ Coverage   99.00%   99.20%   +0.19%     
==========================================
  Files         167      201      +34     
  Lines       22211    26480    +4269     
==========================================
+ Hits        21990    26269    +4279     
+ Misses        221      211      -10     
Files Coverage Δ
pennylane_lightning/core/_version.py 100.00% <100.00%> (ø)
pennylane_lightning/core/lightning_base.py 100.00% <100.00%> (ø)
...rc/simulators/lightning_gpu/StateVectorCudaMPI.hpp 99.62% <100.00%> (ø)
...lightning_gpu/algorithms/AdjointJacobianGPUMPI.hpp 96.66% <ø> (ø)
...rs/lightning_gpu/observables/ObservablesGPUMPI.hpp 100.00% <100.00%> (ø)
...rc/simulators/lightning_gpu/utils/MPILinearAlg.hpp 100.00% <100.00%> (ø)
pennylane_lightning/lightning_gpu/lightning_gpu.py 85.94% <100.00%> (-1.72%) ⬇️

... and 53 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr added the ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request label Oct 30, 2023
@vincentmr vincentmr marked this pull request as ready for review October 30, 2023 18:36
@vincentmr vincentmr requested a review from a team October 30, 2023 18:36
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to approve, but let's merge after #538 and then after the CI goes green.

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Thanks!

@vincentmr vincentmr merged commit e38639d into master Oct 31, 2023
81 checks passed
@vincentmr vincentmr deleted the compatibility/mpi branch October 31, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-multi-gpu-runner Enable usage of Multi-GPU runner for this Pull Request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants