Add updates for CUDA 12 libraries #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlxd
added
the
ci:use-multi-gpu-runner
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #617 +/- ##
==========================================
+ Coverage 98.70% 98.85% +0.15%
==========================================
Files 169 203 +34
Lines 24019 29419 +5400
==========================================
+ Hits 23707 29082 +5375
- Misses 312 337 +25 ☔ View full report in Codecov by Sentry. |
mlxd
changed the title
vincentmr
approved these changes
Feb 23, 2024
pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuError.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuError.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuError.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuError.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuError.hpp
Outdated
Show resolved
Hide resolved
pennylane_lightning/core/src/simulators/lightning_gpu/utils/cuError.hpp
Outdated
Show resolved
Hide resolved
…Error.hpp Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
…Error.hpp Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
…Error.hpp Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
…Error.hpp Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
…Error.hpp Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
…Error.hpp Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: This PR updates the reported error messages from CUDA specific libraries, and avoids unversioned libs from being included in wheel builds (such as when using the NVHPC toolkit).
Description of the Change: As above. Ensure better error messaging and reporting on complex systems (such as Perlmutter).
Benefits:
Possible Drawbacks:
Related GitHub Issues: