Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unsupported gates from toml file. #698

Merged
merged 4 commits into from
Apr 24, 2024

Conversation

erick-xanadu
Copy link
Contributor

@erick-xanadu erick-xanadu commented Apr 24, 2024

Context: Three gates where removed from lightning.qubit supported gates.

Description of the Change: Remove these gates from the TOML file.

Benefits: Catalyst's gate verification passes.

[sc-62310]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🙌

@maliasadi maliasadi added the ci:build_wheels Activate wheel building. label Apr 24, 2024
Copy link

codecov bot commented Apr 24, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.62%. Comparing base (72da7e1) to head (bd83fea).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #698      +/-   ##
==========================================
- Coverage   95.42%   91.62%   -3.81%     
==========================================
  Files         174      150      -24     
  Lines       22814    18047    -4767     
  Branches      363        0     -363     
==========================================
- Hits        21771    16535    -5236     
- Misses       1043     1512     +469     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @erick-xanadu!

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You don't need me, but LGMT!

@maliasadi
Copy link
Member

maliasadi commented Apr 24, 2024

😄 thanks! tagged you @vincentmr as I wasn't sure if Amintor would have time to check this PR.

@erick-xanadu erick-xanadu merged commit 5feb4a1 into master Apr 24, 2024
79 of 80 checks passed
@erick-xanadu erick-xanadu deleted the eochoa/2024-04-24/remove-unsupported-gates branch April 24, 2024 21:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants