Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add default.tensor to setup.py #719

Merged
merged 12 commits into from
May 10, 2024
Merged

Add default.tensor to setup.py #719

merged 12 commits into from
May 10, 2024

Conversation

mudit2812
Copy link
Contributor

As name says.

  • default.tensor is the updated name of the tensor network device with the quimb backend. The new change installs it along with lightning.qubit as there are no non-python dependencies to get the device to work.
  • Updated the device's name attribute to return default.tensor instead of lightning.tensor.
  • Updated the errors raised by the device to use default.tensor instead of LightningTensor or lightning.tensor.

@mudit2812 mudit2812 added the ci:build_wheels Activate wheel building. label May 8, 2024
setup.py Outdated Show resolved Hide resolved
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Mudit --- can we confirm when building this as a wheel the new folders/files are also included?

Copy link

codecov bot commented May 8, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.67%. Comparing base (279f7e8) to head (84f7b82).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #719      +/-   ##
==========================================
- Coverage   95.70%   93.67%   -2.03%     
==========================================
  Files          91       16      -75     
  Lines       14054     1835   -12219     
==========================================
- Hits        13450     1719   -11731     
+ Misses        604      116     -488     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

setup.py Show resolved Hide resolved
@mudit2812
Copy link
Contributor Author

[sc-61741]

@PietropaoloFrisoni
Copy link
Contributor

This is obviously a statistical fluctuation. Codecov keeps complaining, but at this point I am not surprised

@mudit2812 mudit2812 requested a review from mlxd May 9, 2024 14:33
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we want to replace the following too?

pennylane_lightning/lightning_tensor/backends/quimb/_mps.py:    """A function that determines if an operation is supported by ``lightning.tensor`` for this interface."""
pennylane_lightning/lightning_tensor/backends/quimb/_mps.py:    """A function that determines if an observable is supported by ``lightning.tensor`` for this interface."""
pennylane_lightning/lightning_tensor/lightning_tensor.py:    """A function that determines whether or not a backend is supported by ``lightning.tensor``."""
pennylane_lightning/lightning_tensor/lightning_tensor.py:    """A function that determines whether or not a method is supported by ``lightning.tensor``."""

@mudit2812
Copy link
Contributor Author

Do we want to replace the following too?

pennylane_lightning/lightning_tensor/backends/quimb/_mps.py:    """A function that determines if an operation is supported by ``lightning.tensor`` for this interface."""
pennylane_lightning/lightning_tensor/backends/quimb/_mps.py:    """A function that determines if an observable is supported by ``lightning.tensor`` for this interface."""
pennylane_lightning/lightning_tensor/lightning_tensor.py:    """A function that determines whether or not a backend is supported by ``lightning.tensor``."""
pennylane_lightning/lightning_tensor/lightning_tensor.py:    """A function that determines whether or not a method is supported by ``lightning.tensor``."""

Where is this from?

@vincentmr
Copy link
Contributor

Where is this from?

I was looking for the lightning.tensor string in files with grep -r "lightning\.tensor" pennylane_lightning/.

Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No more concerns from my side. Thanks @mudit2812
Feel free to merge once all CI runs are green.

Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, thanks @mudit2812 .

@mlxd mlxd merged commit 3187d24 into master May 10, 2024
80 of 81 checks passed
@mlxd mlxd deleted the default-tensor branch May 10, 2024 13:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:build_wheels Activate wheel building.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants