Trim down MCM tests. #754
Merged
Trim down MCM tests. #754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #754 +/- ##
==========================================
- Coverage 93.40% 92.71% -0.70%
==========================================
Files 120 15 -105
Lines 17462 1729 -15733
==========================================
- Hits 16311 1603 -14708
+ Misses 1151 126 -1025 ☔ View full report in Codecov by Sentry. |
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
AmintorDusko
approved these changes
Jun 10, 2024
multiphaseCFD
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Thanks @vincentmr ! Just a few question but happy to approve.
multiphaseCFD
pushed a commit
that referenced
this pull request
Jun 10, 2024
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [x] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:**
MCM tests are slow and dominate the CI run time. New tests have been
incorporated as new features came in without rationalizing the test
suite as a whole. There are redundant or overly parametrized tests as a
results.
**Description of the Change:**
Combine a bunch of tests into `test_simple_dynamic_circuit` which tests
all possible measurements are handle correctly by `dynamic_one_shot`
post-processing. This needs not be parametrized over `reset` since it
does not show up in post-processing.
Combine some tests into `test_multiple_measurements_and_reset` which
checks that multiple measurements are handle correctly and that `reset`
is properly applied while getting to the final state.
Combine all composite MCM measurements in `test_composite_mcms`.
`test_counts_return_type` remains as is.
**Benefits:**
Faster CI.
**Possible Drawbacks:**
**Related GitHub Issues:**
[sc-65255]
---------
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Co-authored-by: Amintor Dusko <87949283+AmintorDusko@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
MCM tests are slow and dominate the CI run time. New tests have been incorporated as new features came in without rationalizing the test suite as a whole. There are redundant or overly parametrized tests as a results.
Description of the Change:
Combine a bunch of tests into
test_simple_dynamic_circuitwhich tests all possible measurements are handle correctly bydynamic_one_shotpost-processing. This needs not be parametrized overresetsince it does not show up in post-processing.Combine some tests into
test_multiple_measurements_and_resetwhich checks that multiple measurements are handle correctly and thatresetis properly applied while getting to the final state.Combine all composite MCM measurements in
test_composite_mcms.test_counts_return_typeremains as is.Benefits:
Faster CI.
Possible Drawbacks:
Related GitHub Issues:
[sc-65255]