Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't patch probs(wires=[]) to probs(all_wires) in LK #762

Merged
merged 2 commits into from
Jun 17, 2024

Conversation

maliasadi
Copy link
Member

@maliasadi maliasadi commented Jun 17, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
PR #744 patches probs(wires=[]) to calculate the probabilities of all wires in LightningKokkos. This PR fixes the issue to keep the consistency among all Lightning devices as well as the integration with Catalyst.

Description of the Change:

Benefits:
Consistent behaviour among all devices for calculating probs(wires=[]) = [1.0].

Possible Drawbacks:

Related GitHub Issues:

[sc-66316]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Jun 17, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.13%. Comparing base (f8097d5) to head (9085d8e).
Report is 96 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #762      +/-   ##
==========================================
- Coverage   95.22%   94.13%   -1.09%     
==========================================
  Files         122       68      -54     
  Lines       17742     9217    -8525     
==========================================
- Hits        16894     8676    -8218     
+ Misses        848      541     -307     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@maliasadi maliasadi requested review from dime10 and a team June 17, 2024 16:19
Copy link
Contributor

@vincentmr vincentmr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.

@maliasadi maliasadi requested a review from mlxd June 17, 2024 16:53
Copy link
Member

@mlxd mlxd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I assume this fixes something that broke in Catalyst with LK?
Approved.

@maliasadi maliasadi merged commit 97fbeb2 into master Jun 17, 2024
78 of 79 checks passed
@maliasadi maliasadi deleted the fix-zero-wires-probs-patch branch June 17, 2024 19:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants