Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set PL_BACKEND in L-GPU docker build and misc improvements #791

Merged
merged 4 commits into from
Jul 10, 2024

Conversation

vincentmr
Copy link
Contributor

@vincentmr vincentmr commented Jul 9, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
The Lightning-GPU Docker image has not installed the wheel correctly as the wheel-building command was missing the environment variable PL_BACKEND=lightning_gpu.

Description of the Change:
Set the environment variable PL_BACKEND=lightning_gpu in the build-wheel-lightning-gpu Docker-build stage.
Enhance Docker-related make commands.
Enable Dockerfile level defaults for build arguments.
Set the default Lightning and PennyLane versions to master.

Benefits:
L-GPU installs the correct wheels.
No need to update hardcoded tags/versions since master is moving.

Possible Drawbacks:

Related GitHub Issues:
[sc-68127]

Copy link

codecov bot commented Jul 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 93.11%. Comparing base (be07bbe) to head (632c35d).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #791      +/-   ##
==========================================
- Coverage   94.95%   93.11%   -1.84%     
==========================================
  Files         132       17     -115     
  Lines       19542     1904   -17638     
==========================================
- Hits        18557     1773   -16784     
+ Misses        985      131     -854     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vincentmr vincentmr marked this pull request as ready for review July 9, 2024 20:24
@vincentmr vincentmr requested a review from a team July 9, 2024 20:27
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @vincentmr!

docker/Dockerfile Show resolved Hide resolved
docker/Dockerfile Outdated Show resolved Hide resolved
@vincentmr vincentmr requested review from a team and multiphaseCFD July 10, 2024 12:48
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@vincentmr vincentmr merged commit 286fb7f into master Jul 10, 2024
84 of 85 checks passed
@vincentmr vincentmr deleted the update_docker_version_037 branch July 10, 2024 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants