Fix sync issues with calls to CUSV APIs on aarch64 #823
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello. You may have forgotten to update the changelog!
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #823 +/- ##
==========================================
+ Coverage 97.60% 99.20% +1.60%
==========================================
Files 116 102 -14
Lines 18259 13837 -4422
==========================================
- Hits 17821 13727 -4094
+ Misses 438 110 -328 ☔ View full report in Codecov by Sentry. |
|
Fixes #793 |
mlxd
added
the
ci:use-multi-gpu-runner
multiphaseCFD
approved these changes
Jul 30, 2024
There was a problem hiding this comment.
Looks good to me! Thanks @mlxd ! Don't forget to add a changelog entry.
pennylane_lightning/core/src/simulators/lightning_gpu/measurements/MeasurementsGPU.hpp
Outdated
Show resolved
Hide resolved
maliasadi
reviewed
Jul 30, 2024
5 tasks
|
[sc-68294] |
maliasadi
approved these changes
Aug 2, 2024
### Before submitting
Please complete the following checklist when submitting a PR:
- [ ] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [ ] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [ ] Ensure that the test suite passes, by running `make test`.
- [ ] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [ ] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:** Current install directions for cuquantum allow use of the
RPATH to the expected directory with Python, but requires explicit
targets when using a C++ build. The docs and paths searched for
cuquantum right now often have the `lib` dir implicit in the path, which
causes an incorrect path to be found by CMake, as it is a child class of
the root. This PR fixes those such paths, allowing the C++ builds to
find the correct custatevec libraries, ensuring a successful cmake
configuration step.
**Description of the Change:** As above.
**Benefits:**
**Possible Drawbacks:**
**Related GitHub Issues:**
---------
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
…ightning into fix_lgpu_aarch64
multiphaseCFD
pushed a commit
that referenced
this pull request
Aug 2, 2024
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [x] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:** Fixes the known sync issues on aarch64 + GraceHopper when
using custatevec API calls.
**Description of the Change:** Adds stream sync to all CUSV async API
calls.
**Benefits:** Fixes #793
**Possible Drawbacks:** Potential sync point may introduce (minimal)
overhead for smaller problems.
**Related GitHub Issues:**
---------
Co-authored-by: Lee J. O'Riordan <lee@xanadu.au>
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
multiphaseCFD
pushed a commit
that referenced
this pull request
Aug 5, 2024
Please complete the following checklist when submitting a PR:
- [x] All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to
the
[`tests`](../tests) directory!
- [x] All new functions and code must be clearly commented and
documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running `make docs`.
- [x] Ensure that the test suite passes, by running `make test`.
- [x] Add a new entry to the `.github/CHANGELOG.md` file, summarizing
the
change, and including a link back to the PR.
- [x] Ensure that code is properly formatted by running `make format`.
When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
------------------------------------------------------------------------------------------------------------
**Context:** Fixes the known sync issues on aarch64 + GraceHopper when
using custatevec API calls.
**Description of the Change:** Adds stream sync to all CUSV async API
calls.
**Benefits:** Fixes #793
**Possible Drawbacks:** Potential sync point may introduce (minimal)
overhead for smaller problems.
**Related GitHub Issues:**
---------
Co-authored-by: Lee J. O'Riordan <lee@xanadu.au>
Co-authored-by: ringo-but-quantum <github-ringo-but-quantum@xanadu.ai>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
testsdirectory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs.Ensure that the test suite passes, by running
make test.Add a new entry to the
.github/CHANGELOG.mdfile, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context: Fixes the known sync issues on aarch64 + GraceHopper when using custatevec API calls.
Description of the Change: Adds stream sync to all CUSV async API calls.
Benefits: Fixes #793
Possible Drawbacks: Potential sync point may introduce (minimal) overhead for smaller problems.
Related GitHub Issues: