-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add (check) full support for sampling in full parity with Lightning. #908
Conversation
Hello. You may have forgotten to update the changelog!
|
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
…-lightning into gpuNewAPI_simulate
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## gpuNewAPI_backend #908 +/- ##
======================================================
- Coverage 93.77% 56.16% -37.61%
======================================================
Files 110 28 -82
Lines 13968 2345 -11623
======================================================
- Hits 13098 1317 -11781
- Misses 870 1028 +158 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work @LuisAlfredoNu!
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Before submitting
Please complete the following checklist when submitting a PR:
All new features must include a unit test.
If you've fixed a bug or added code that should be tested, add a test to the
tests
directory!All new functions and code must be clearly commented and documented.
If you do make documentation changes, make sure that the docs build and
render correctly by running
make docs
.Ensure that the test suite passes, by running
make test
.Add a new entry to the
.github/CHANGELOG.md
file, summarizing thechange, and including a link back to the PR.
Ensure that code is properly formatted by running
make format
.When all the above are checked, delete everything above the dashed
line and fill in the pull request template.
Context:
Migrate LightningGPU to the new device API
Description of the Change:
Add all the functionality of the new device API to LGPU.
Benefits:
Possible Drawbacks:
Related GitHub Issues:
Freezzed PR⚠️ ❄️
To make a smooth integration of LightningGPU with the new device API, we set the branch
gpuNewAPI_backend
as the base branch target for future developments related to this big task.The branch
gpuNewAPI_backend
has the mock of all classes and methods necessary for the new API. Also, several tests were disabled withHowever, these tests will unblocked as the implementation progresses.
After all the developments for integrating LightningGPU with the new API have been completed then the PR will be open to merge to
master
[sc-70946]