Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add (check) full support for sampling in full parity with Lightning. #908

Merged
merged 62 commits into from
Sep 18, 2024

Conversation

LuisAlfredoNu
Copy link
Contributor

@LuisAlfredoNu LuisAlfredoNu commented Sep 11, 2024

Before submitting

Please complete the following checklist when submitting a PR:

  • All new features must include a unit test.
    If you've fixed a bug or added code that should be tested, add a test to the
    tests directory!

  • All new functions and code must be clearly commented and documented.
    If you do make documentation changes, make sure that the docs build and
    render correctly by running make docs.

  • Ensure that the test suite passes, by running make test.

  • Add a new entry to the .github/CHANGELOG.md file, summarizing the
    change, and including a link back to the PR.

  • Ensure that code is properly formatted by running make format.

When all the above are checked, delete everything above the dashed
line and fill in the pull request template.


Context:
Migrate LightningGPU to the new device API

Description of the Change:
Add all the functionality of the new device API to LGPU.

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Freezzed PR ⚠️ ❄️

To make a smooth integration of LightningGPU with the new device API, we set the branch gpuNewAPI_backend as the base branch target for future developments related to this big task.

The branch gpuNewAPI_backend has the mock of all classes and methods necessary for the new API. Also, several tests were disabled with

if device_name == "lightning.gpu":
    pytest.skip("LGPU new API in WIP.  Skipping.",allow_module_level=True)

However, these tests will unblocked as the implementation progresses.

After all the developments for integrating LightningGPU with the new API have been completed then the PR will be open to merge to master

[sc-70946]

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

LuisAlfredoNu and others added 5 commits September 12, 2024 11:11
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
Co-authored-by: Vincent Michaud-Rioux <vincentm@nanoacademic.com>
@LuisAlfredoNu LuisAlfredoNu marked this pull request as ready for review September 17, 2024 19:11
@LuisAlfredoNu LuisAlfredoNu marked this pull request as draft September 17, 2024 19:14
Copy link

codecov bot commented Sep 17, 2024

Codecov Report

Attention: Patch coverage is 9.63855% with 75 lines in your changes missing coverage. Please review.

Project coverage is 56.16%. Comparing base (a7c4b09) to head (f63a234).
Report is 1 commits behind head on gpuNewAPI_backend.

Files with missing lines Patch % Lines
pennylane_lightning/lightning_gpu/lightning_gpu.py 9.63% 75 Missing ⚠️

❗ There is a different number of reports uploaded between BASE (a7c4b09) and HEAD (f63a234). Click for more details.

HEAD has 3 uploads less than BASE
Flag BASE (a7c4b09) HEAD (f63a234)
9 6
Additional details and impacted files
@@                  Coverage Diff                   @@
##           gpuNewAPI_backend     #908       +/-   ##
======================================================
- Coverage              93.77%   56.16%   -37.61%     
======================================================
  Files                    110       28       -82     
  Lines                  13968     2345    -11623     
======================================================
- Hits                   13098     1317    -11781     
- Misses                   870     1028      +158     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@LuisAlfredoNu LuisAlfredoNu marked this pull request as ready for review September 17, 2024 19:36
@LuisAlfredoNu LuisAlfredoNu added ci:build_wheels Activate wheel building. ci:use-gpu-runner Enable usage of GPU runner for this Pull Request labels Sep 17, 2024
@LuisAlfredoNu LuisAlfredoNu removed the ci:build_wheels Activate wheel building. label Sep 17, 2024
@AmintorDusko AmintorDusko added the urgent Mark a pull request as high priority label Sep 18, 2024
Copy link
Contributor

@AmintorDusko AmintorDusko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work @LuisAlfredoNu!

tests/new_api/test_device.py Outdated Show resolved Hide resolved
pennylane_lightning/lightning_gpu/lightning_gpu.py Outdated Show resolved Hide resolved
pennylane_lightning/lightning_gpu/lightning_gpu.py Outdated Show resolved Hide resolved
LuisAlfredoNu and others added 3 commits September 18, 2024 15:27
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@LuisAlfredoNu LuisAlfredoNu merged commit b67eb2b into gpuNewAPI_backend Sep 18, 2024
69 of 74 checks passed
@LuisAlfredoNu LuisAlfredoNu deleted the gpuNewAPI_fullSupport branch September 18, 2024 19:47
@LuisAlfredoNu LuisAlfredoNu restored the gpuNewAPI_fullSupport branch September 18, 2024 19:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ci:use-gpu-runner Enable usage of GPU runner for this Pull Request urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants