Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add label to LightningKokkos GPU CIs #916

Merged
merged 7 commits into from
Sep 19, 2024
Merged

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Sep 19, 2024

Context: Add label to LightningKokkos GPU CIs
Also fixed the workflow activation logic.

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

[sc-74149]

AmintorDusko and others added 3 commits September 19, 2024 16:05
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@AmintorDusko AmintorDusko marked this pull request as ready for review September 19, 2024 20:11
.github/CHANGELOG.md Outdated Show resolved Hide resolved
AmintorDusko and others added 2 commits September 19, 2024 16:12
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
@AmintorDusko AmintorDusko requested review from maliasadi and a team September 19, 2024 20:13
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 55.89%. Comparing base (1acb133) to head (83c0758).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (1acb133) and HEAD (83c0758). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (1acb133) HEAD (83c0758)
7 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #916       +/-   ##
===========================================
- Coverage   92.42%   55.89%   -36.54%     
===========================================
  Files          95       24       -71     
  Lines       11968     2297     -9671     
===========================================
- Hits        11062     1284     -9778     
- Misses        906     1013      +107     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko!

Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko for the nice work!

Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥳

@AmintorDusko AmintorDusko merged commit 05ee305 into master Sep 19, 2024
61 of 62 checks passed
@AmintorDusko AmintorDusko deleted the update/GPU-CIs-LKokkos branch September 19, 2024 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants