Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update plugin test matrix GPU workflow names #918

Merged
merged 9 commits into from
Sep 20, 2024

Conversation

AmintorDusko
Copy link
Contributor

@AmintorDusko AmintorDusko commented Sep 20, 2024

Context: Update plugin test matrix GPU workflow names.
Links:
latest/latest
latest/stable
stable/latest
stable/stable

Description of the Change:

Benefits:

Possible Drawbacks:

Related GitHub Issues:

Copy link
Contributor

Hello. You may have forgotten to update the changelog!
Please edit .github/CHANGELOG.md with:

  • A one-to-two sentence description of the change. You may include a small working example for new features.
  • A link back to this PR.
  • Your name (or GitHub username) in the contributors section.

Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 56.33%. Comparing base (f833461) to head (71c3c9e).
Report is 1 commits behind head on master.

❗ There is a different number of reports uploaded between BASE (f833461) and HEAD (71c3c9e). Click for more details.

HEAD has 2 uploads less than BASE
Flag BASE (f833461) HEAD (71c3c9e)
7 5
Additional details and impacted files
@@             Coverage Diff             @@
##           master     #918       +/-   ##
===========================================
- Coverage   92.42%   56.33%   -36.10%     
===========================================
  Files          95       24       -71     
  Lines       11968     2297     -9671     
===========================================
- Hits        11062     1294     -9768     
- Misses        906     1003       +97     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@AmintorDusko AmintorDusko added the urgent Mark a pull request as high priority label Sep 20, 2024
@AmintorDusko AmintorDusko marked this pull request as ready for review September 20, 2024 16:16
@AmintorDusko AmintorDusko changed the title Update plugin test matrix workflows Update plugin test matrix GPU workflow names Sep 20, 2024
@AmintorDusko AmintorDusko requested a review from a team September 20, 2024 16:19
Copy link
Member

@multiphaseCFD multiphaseCFD left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @AmintorDusko !

AmintorDusko and others added 4 commits September 20, 2024 13:07
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Co-authored-by: Ali Asadi <10773383+maliasadi@users.noreply.github.com>
Copy link
Member

@maliasadi maliasadi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @AmintorDusko!

@AmintorDusko AmintorDusko merged commit aedfac5 into master Sep 20, 2024
59 of 60 checks passed
@AmintorDusko AmintorDusko deleted the fix/plugin-test-matrix branch September 20, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
urgent Mark a pull request as high priority
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants