ADD: Tool to measure DetectorToReference transforms #91
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vaughantnrc
reviewed
Aug 15, 2024
| new_filepath = os.path.join(dir,new_filename) | ||
|
|
||
| with open(new_filepath, 'w') as file: | ||
| # TODO: Make this data look more clean when dumped to file |
There was a problem hiding this comment.
I assume you are referring to the lists of floating points? The coordinates showing up on three different lines rather than all on one line?
There was a problem hiding this comment.
Yes this is what I am referring to, same as the below comment.
|
|
||
| with open(new_filepath, 'w') as file: | ||
| # TODO: Make this data look more clean when dumped to file | ||
| # Also have marker corner positions as floats and not ints |
There was a problem hiding this comment.
I'm not sure why this would be the case. What do you mean by corner positions?
keiranbarr
force-pushed
the
det_to_ref_tool
branch
3 times, most recently
from
baef3e5
to
b8246ab
Compare
keiranbarr
force-pushed
the
det_to_ref_tool
branch
from
b8246ab
to
5fddbf0
Compare
|
Now included in this PR is some improvements that @vaughantnrc made on my own branch, as well as general improvements to the src.slicer_connection module. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Little standalone file to measure the DetectorToReference transforms for each detector. Takes config file specifying detectors and reference board. Outputs the same file* but with the transforms added.
Should address #85