Optimise foreach on builtin::indexed #22641
Draft
+267
−144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This change does have the potential impact that, before it, any modifications to the iterated-on array that happen during the body of its own |
wolfsage
reviewed
Oct 2, 2024
…e OP_ENTERITER and not OP_ITER
leonerd
force-pushed
the
optimise-foreach-indexed
branch
from
bf454f3
to
03618f2
Compare
tonycoz
reviewed
Oct 2, 2024
| @@ -347,6 +347,30 @@ package FetchStoreCounter { | |||
| is(prototype(\&builtin::indexed), '@', 'indexed prototype'); | |||
| } | |||
|
|
|||
| # indexed + foreach loop optimisation appears transparent | |||
There was a problem hiding this comment.
commit message "optimisastion" too many s even for British spelling
There was a problem hiding this comment.
Ahyes, fixed + forcepushed
…cals Rather than generating an entire temporary list that is twice as big as the original array, instead set a flag on the `OP_ITER` that tells it to set one of the iteration variables to the current array index and use the same `CXt_LOOP_ARY` optimisation that regular foreach over an array would use.
leonerd
force-pushed
the
optimise-foreach-indexed
branch
from
03618f2
to
f3d8512
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rather than generating an entire temporary list that is twice as big as the original array, instead set a flag on the
OP_ITERthat tells it to set one of the iteration variables to the current array index and use the sameCXt_LOOP_ARYoptimisastion that regular foreach over an array would use.Currently this is a work-in-progress:
Find a neater solution to the
extern void ...declaration ofXS_builtin_indexedat the top ofop.cConsider whether
builtin::indexed LIST...should do the same optimisationWrite perldelta
This set of changes requires a perldelta entry, and it is not included but I'll write something before un-drafting