Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update to Android Studio 3.1.2 #3975

Merged
merged 1 commit into from
Apr 29, 2018
Merged

Conversation

hannesa2
Copy link
Contributor

This PR updates to most recent stable Android Studio 3.1.2

Copy link
Contributor

@almic almic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few lines can be removed, other than that this looks right.

@@ -4,6 +4,7 @@
import android.graphics.Color;
import android.graphics.Typeface;
import android.os.Bundle;
import android.util.Log;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No reason for this line

xAxis.setDrawAxisLine(false);
xAxis.setDrawGridLines(true);
xAxis.setTextColor(Color.rgb(255, 192, 56));
// xAxis.setTextColor(Color.rgb(255, 192, 56));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can be deleted

@@ -36,6 +37,8 @@ protected void onCreate(@Nullable Bundle savedInstanceState) {

mTfRegular = Typeface.createFromAsset(getAssets(), "OpenSans-Regular.ttf");
mTfLight = Typeface.createFromAsset(getAssets(), "OpenSans-Light.ttf");

Log.d("OpenActivity", this.getClass().getName());

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess there is no reason for this change either (and its import).

distributionBase=GRADLE_USER_HOME
distributionPath=wrapper/dists
zipStoreBase=GRADLE_USER_HOME
zipStorePath=wrapper/dists
distributionUrl=https\://services.gradle.org/distributions/gradle-4.1-all.zip
distributionUrl=https\://services.gradle.org/distributions/gradle-4.4-all.zip

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The latest version of Gradle is 4.7.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

gradle build tools 3.1.2 doesn't work with gradle > 4.5

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to the doc, it should be compatible with Gradle 4.4+. If it doesn't, I guess there is a bug in either the plugin or Gradle.

Plugin version Required Gradle version
3.1.0+ 4.4+

@hannesa2
Copy link
Contributor Author

Sorry there were to much local changes in the PR. I changed this.
Btw, a lot of other things could be changed, but this is out of scope here
eg:
image

@almic
Copy link
Contributor

almic commented Apr 29, 2018

It does seem that new gradle versions are available, however since Android Studio is only automatically updating to 4.4, that should be fine for now. I just built this version and it worked, merging.

@almic almic merged commit 9997a33 into PhilJay:master Apr 29, 2018
@hannesa2
Copy link
Contributor Author

gradle build tools 3.1.2 doesn't work with gradle > 4.5

Failed to apply plugin [id 'com.android.application']
Configuration on demand is not supported by the current version of the Android Gradle plugin since you are using Gradle version 4.6 or above. Suggestion: disable configuration on demand by setting org.gradle.configureondemand=false in your gradle.properties file or use a Gradle version less than 4.6.

First suggestion doesn't work too.
If you have a better way, let us know

@hannesa2 hannesa2 deleted the AndroidStudio3.1.2 branch July 31, 2018 09:00
regas99 pushed a commit to regas99/MPAndroidChart that referenced this pull request Apr 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants