Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fixes to be compatible with PHP 8.1 #302

Merged
merged 6 commits into from
Nov 13, 2021

Conversation

andrewbess
Copy link

@andrewbess andrewbess commented Nov 13, 2021

This pull request (PR) provides fixes for the extension to make it compatible with PHP 8.1.
The fixes provides backward compatibility with previous versions PHP.

The fixes provided below

  • the necessary constraints have been fixed if composer.json file
  • composer dependencies have been updated to be compatible with PHP 7.3, 7.4, 8.0, 8.1
  • return types have been fixed using attribute #[\ReturnTypeWillChange], please see this link
  • The error "PHP Deprecated: explode(): Passing null to parameter W3 DOM Level 2 changes #2 ($string) of type string is deprecated" have been fixed. Please see this RFC document

Test results
Tests have been run on the local environment with PHP 7.3, 7.4, 8.0, 8.1RC6. Please see testdox results below

testdox73.txt
testdox74.txt
testdox80.txt
testdox81.txt

@g105b
Copy link
Member

g105b commented Nov 13, 2021

Hi @andrewbess,

This looks great. Thank you so much for your contribution. I will look over this now and once merged, I'll release it to 2.2.2.

Thanks,
Greg.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants