update base conf

PikaLabs · Sep 11, 2017 · f42b658 · f42b658
1 parent f17f327
commit f42b658
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 12 deletions.
diff --git a/slash/include/base_conf.h b/slash/include/base_conf.h
@@ -3,10 +3,11 @@
 // LICENSE file in the root directory of this source tree. An additional grant
 // of patent rights can be found in the PATENTS file in the same directory.
 
-#ifndef INCLUDE_BASE_CONF_H_
-#define INCLUDE_BASE_CONF_H_
-#include "stdlib.h"
-#include "stdio.h"
+#ifndef SLASH_INCLUDE_BASE_CONF_H_
+#define SLASH_INCLUDE_BASE_CONF_H_
+
+#include <stdlib.h>
+#include <stdio.h>
 
 #include <string>
 #include <vector>
@@ -15,15 +16,15 @@
 
 namespace slash {
 
-class BaseConf
-{
-public:
+class BaseConf {
+ public:
   explicit BaseConf(const std::string &path);
   virtual ~BaseConf();
 
   int LoadConf();
   int32_t ReloadConf();
 
+  // return false if the item dosen't exist
   bool GetConfInt(const std::string &name, int* value) const;
   bool GetConfInt64(const std::string &name, int64_t* value) const;
 
@@ -42,8 +43,7 @@ class BaseConf
   bool WriteBack();
   void WriteSampleConf() const;
 
-private:
-
+ private:
   struct Rep;
   Rep* rep_;
 
@@ -56,4 +56,4 @@ class BaseConf
 
 }  // namespace slash
 
-#endif  // INCLUDE_BASE_CONF_H_
+#endif  // SLASH_INCLUDE_BASE_CONF_H_
diff --git a/slash/src/base_conf.cc b/slash/src/base_conf.cc
@@ -40,7 +40,7 @@ struct BaseConf::Rep {
     {}
   };
 
-  Rep(const std::string &p)
+  explicit Rep(const std::string &p)
     : path(p) {
     }
   std::vector<ConfItem> item;
@@ -262,7 +262,7 @@ bool BaseConf::SetConfBool(const std::string &name, const bool value) {
 
 bool BaseConf::SetConfStrVec(const std::string& name, const std::vector<std::string> &value) {
   std::string value_str = StringConcat(value, COMMA);
-  return SetConfStr(name, value_str); 
+  return SetConfStr(name, value_str);
 }
 
 void BaseConf::DumpConf() const {