Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing git.rs #47

Merged
merged 17 commits into from
Apr 2, 2024
Merged

Testing git.rs #47

merged 17 commits into from
Apr 2, 2024

Conversation

Pilou97
Copy link
Owner

@Pilou97 Pilou97 commented Apr 2, 2024

Context

First of all I am sorry for this big merge requests. Let me introduce all the changes.

This MR mainly tests git.rs to ensure how the behavior of the primitives exposed by git.rs are working.
However this MR also introduces some bug fixes that was discovered during the implementation of the tests.

  • some typo was fixed in the code/doc
  • document some functions
  • anyhow is now used to return better error
  • useless requirement of Clone
  • deleting the note of a commit that does not contains any notes was returning an error (it's no more the case)
  • split the code to be more test friendly.

This MR is using lcov to compute the test coverage. It will be later added in another MR

@Pilou97 Pilou97 mentioned this pull request Apr 2, 2024
@Pilou97 Pilou97 force-pushed the pilou@test branch 2 times, most recently from aecaba5 to 5679633 Compare April 2, 2024 16:01
@Pilou97 Pilou97 force-pushed the pilou@test branch 2 times, most recently from 54fec71 to 563b14e Compare April 2, 2024 16:15
This commit adds two main stuff:
 - git client wrapper
 - tests

 git.rs is then tested against git client
@Pilou97
Copy link
Owner Author

Pilou97 commented Apr 2, 2024

Ok I force pushed and lost my work, now tests are working fine.

@Pilou97 Pilou97 merged commit 6b66ff7 into main Apr 2, 2024
1 check passed
@Pilou97 Pilou97 deleted the pilou@test branch April 2, 2024 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant