Skip to content

Commit

Permalink
review: enable snapshot compression.
Browse files Browse the repository at this point in the history
Signed-off-by: Piotr Sikora <piotrsikora@google.com>
  • Loading branch information
PiotrSikora committed Dec 16, 2021
1 parent 71a803e commit 10a263a
Showing 1 changed file with 28 additions and 19 deletions.
47 changes: 28 additions & 19 deletions bazel/external/wee8.patch
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
10. Fix build on Linux/aarch64 (https://crrev.com/c/3337367).
11. Link statically (https://crrev.com/c/3295460).
12. Fix build with GCC (https://crrev.com/c/3333635).
13. Enable snapshot compression.
--- BUILD.bazel
+++ BUILD.bazel
@@ -17,6 +17,7 @@
Expand Down Expand Up @@ -56,7 +57,15 @@
":is_v8_enable_backtrace",
],
)
@@ -299,26 +300,26 @@
@@ -291,6 +292,7 @@
"ENABLE_DEBUGGER_SUPPORT",
"V8_ADVANCED_BIGINT_ALGORITHMS",
"V8_CONCURRENT_MARKING",
+ "V8_SNAPSHOT_COMPRESSION",
] + select({
":is_debug": [
"DEBUG",
@@ -299,26 +301,26 @@
"//conditions:default": [],
}) + select(
{
Expand Down Expand Up @@ -90,7 +99,7 @@
"V8_HAVE_TARGET_OS",
"V8_TARGET_OS_MACOSX",
],
@@ -595,7 +596,7 @@
@@ -595,7 +597,7 @@
"src/base/vlq-base64.cc",
"src/base/vlq-base64.h",
] + select({
Expand All @@ -99,7 +108,7 @@
"src/base/platform/platform-posix.cc",
"src/base/platform/platform-posix.h",
"src/base/platform/platform-posix-time.cc",
@@ -603,15 +604,15 @@
@@ -603,15 +605,15 @@
],
"//conditions:default": [],
}) + select({
Expand All @@ -118,7 +127,7 @@
"src/base/debug/stack_trace_posix.cc",
"src/base/platform/platform-macos.cc",
],
@@ -2027,7 +2028,7 @@
@@ -2027,7 +2029,7 @@
"src/heap/third-party/heap-api.h",
"src/heap/third-party/heap-api-stub.cc",
] + select({
Expand All @@ -127,7 +136,7 @@
"src/baseline/ia32/baseline-assembler-ia32-inl.h",
"src/baseline/ia32/baseline-compiler-ia32-inl.h",
"src/codegen/shared-ia32-x64/macro-assembler-shared-ia32-x64.h",
@@ -2055,7 +2056,7 @@
@@ -2055,7 +2057,7 @@
"src/regexp/ia32/regexp-macro-assembler-ia32.h",
"src/wasm/baseline/ia32/liftoff-assembler-ia32.h",
],
Expand All @@ -136,7 +145,7 @@
"src/baseline/x64/baseline-assembler-x64-inl.h",
"src/baseline/x64/baseline-compiler-x64-inl.h",
"src/codegen/shared-ia32-x64/macro-assembler-shared-ia32-x64.h",
@@ -2087,7 +2088,7 @@
@@ -2087,7 +2089,7 @@
"src/regexp/x64/regexp-macro-assembler-x64.h",
"src/wasm/baseline/x64/liftoff-assembler-x64.h",
],
Expand All @@ -145,7 +154,7 @@
"src/baseline/arm/baseline-assembler-arm-inl.h",
"src/baseline/arm/baseline-compiler-arm-inl.h",
"src/codegen/arm/assembler-arm-inl.h",
@@ -2118,7 +2119,7 @@
@@ -2118,7 +2120,7 @@
"src/regexp/arm/regexp-macro-assembler-arm.h",
"src/wasm/baseline/arm/liftoff-assembler-arm.h",
],
Expand All @@ -154,7 +163,7 @@
"src/baseline/arm64/baseline-assembler-arm64-inl.h",
"src/baseline/arm64/baseline-compiler-arm64-inl.h",
"src/codegen/arm64/assembler-arm64-inl.h",
@@ -2163,13 +2164,13 @@
@@ -2163,13 +2165,13 @@
],
}) + select({
# Only for x64 builds and for arm64 with x64 host simulator.
Expand All @@ -170,7 +179,7 @@
"src/trap-handler/trap-handler-simulator.h",
"src/trap-handler/handler-outside-simulator.cc",
],
@@ -2651,10 +2652,10 @@
@@ -2651,10 +2653,10 @@
"src/interpreter/interpreter-intrinsics-generator.cc",
"src/interpreter/interpreter-intrinsics-generator.h",
] + select({
Expand All @@ -185,15 +194,15 @@
}) + select({
":is_v8_enable_webassembly": [
"src/builtins/builtins-wasm-gen.cc",
@@ -2717,6 +2718,7 @@
@@ -2717,6 +2719,7 @@
"src/heap/cppgc/marking-visitor.h",
"src/heap/cppgc/marking-worklists.cc",
"src/heap/cppgc/marking-worklists.h",
+ "src/heap/cppgc/memory.cc",
"src/heap/cppgc/memory.h",
"src/heap/cppgc/metric-recorder.h",
"src/heap/cppgc/name-trait.cc",
@@ -2770,10 +2772,10 @@
@@ -2770,10 +2773,10 @@
# Note these cannot be v8_target_is_* selects because these contain
# inline assembly that runs inside the executable. Since these are
# linked directly into mksnapshot, they must use the actual target cpu.
Expand All @@ -208,7 +217,7 @@
}),
)

@@ -2927,16 +2929,16 @@
@@ -2927,16 +2930,16 @@
srcs = [
"src/init/setup-isolate-deserialize.cc",
] + select({
Expand All @@ -229,7 +238,7 @@
}),
)

@@ -2945,16 +2947,16 @@
@@ -2945,16 +2948,16 @@
srcs = [
"src/init/setup-isolate-deserialize.cc",
] + select({
Expand All @@ -250,7 +259,7 @@
}),
)

@@ -2980,7 +2982,7 @@
@@ -2980,7 +2983,7 @@
":is_v8_annotate_torque_ir": ["-annotate-ir"],
"//conditions:default": [],
}) + select({
Expand All @@ -259,7 +268,7 @@
"//conditions:default": [],
}),
extras = [
@@ -3032,7 +3034,7 @@
@@ -3032,7 +3035,7 @@
"src/inspector/protocol/Schema.cpp",
"src/inspector/protocol/Schema.h",
],
Expand All @@ -268,7 +277,7 @@
local = 1,
message = "Generating inspector files",
)
@@ -3177,7 +3179,7 @@
@@ -3177,7 +3180,7 @@
],
deps = [
":v8_libbase",
Expand All @@ -277,7 +286,7 @@
],
)

@@ -3194,7 +3196,27 @@
@@ -3194,7 +3197,27 @@
v8_library(
name = "wee8",
srcs = [":wee8_files"],
Expand Down Expand Up @@ -306,7 +315,7 @@
)

alias(
@@ -3253,7 +3275,7 @@
@@ -3253,7 +3276,7 @@
copts = ["-fexceptions"],
features = ["-use_header_modules"],
linkopts = select({
Expand All @@ -315,7 +324,7 @@
"//conditions:default": [],
}),
deps = ["v8_libbase"],
@@ -3264,7 +3286,7 @@
@@ -3264,7 +3287,7 @@
srcs = [":mksnapshot_files"],
icu_deps = [":icu/v8_libshared"],
linkopts = select({
Expand Down

0 comments on commit 10a263a

Please sign in to comment.