Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[IMPORT][ALEMBIC]fix:downgrade revision add constraint error #2938

Open
wants to merge 1 commit into
base: feat/import
Choose a base branch
from

Conversation

andriacap
Copy link
Contributor

Cannot add constraint unicity_t_mappings_fields_name_field (fix by delete duplicate vaulue)
Cannot add foreign key id_theme to bib_field (fix by set default value )

Maybe this PR should be gathered with other works about the topic : update/downgrade import

Reviewed-by: andriacap

Copy link

codecov bot commented Feb 29, 2024

Codecov Report

Attention: Patch coverage is 92.22011% with 164 lines in your changes are missing coverage. Please review.

Project coverage is 81.80%. Comparing base (02c84bc) to head (272d87f).
Report is 212 commits behind head on feat/import.

Files Patch % Lines
backend/geonature/core/imports/routes/imports.py 85.08% 58 Missing ⚠️
backend/geonature/core/imports/models.py 90.74% 31 Missing ⚠️
backend/geonature/core/imports/tasks.py 85.71% 9 Missing ⚠️
backend/geonature/core/imports/admin.py 82.60% 8 Missing ⚠️
backend/geonature/core/imports/checks/sql/core.py 81.57% 7 Missing ⚠️
backend/geonature/core/imports/routes/__init__.py 66.66% 6 Missing ⚠️
...cchab/backend/gn_module_occhab/imports/__init__.py 94.79% 5 Missing ⚠️
backend/geonature/celery_app.py 0.00% 4 Missing ⚠️
...d/geonature/core/imports/checks/dataframe/dates.py 86.66% 4 Missing ⚠️
...onature/core/imports/checks/dataframe/geography.py 96.07% 4 Missing ⚠️
... and 13 more
Additional details and impacted files
@@               Coverage Diff               @@
##           feat/import    #2938      +/-   ##
===============================================
+ Coverage        78.44%   81.80%   +3.36%     
===============================================
  Files               89      120      +31     
  Lines             7213     9300    +2087     
===============================================
+ Hits              5658     7608    +1950     
- Misses            1555     1692     +137     
Flag Coverage Δ
pytest 81.80% <92.22%> (+3.36%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Cannot add constraint unicity_t_mappings_fields_name_field (fix by delete duplicate vaulue)
Cannot add foreign key id_theme to bib_field (fix by set default value )

Reviewed-by: andriacap
@bouttier bouttier force-pushed the fix/downgrade-revision-2b0b3bd0248c branch from 272d87f to fa626ee Compare August 14, 2024 17:12
@bouttier bouttier self-requested a review August 14, 2024 17:12
@bouttier
Copy link
Contributor

Rebasé, mais reste encore à relire.

@bouttier
Copy link
Contributor

On a discuté de la stratégie sur les downgrades, et ceux-cis ne doivent pas supprimer de donner pour si jamais ils sont lancé en prod. C’est à l’admin / aux devs de supprimer manuellement les données qui posent problème (après s’être assuré de ne pas supprimer de donner essentiel). On est donc plutôt d’avis de ne pas intégrer cette évolution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants