Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor JS for improved data extraction #1

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

Spomky
Copy link

@Spomky Spomky commented Aug 28, 2024

Hi 👋🏼,

Thank you for your very interesting demo.
I am working on a small web app that will collect distances and angles from the PLR50C.
I tweak your code a bit to make sure the correct data is received.

Available data:

  • Device mode
  • Reference of the edge
  • Device status (warnings, metric system, laser status...)
  • Unique ID
  • Result, Component1 and Component2 (useful for e.g. min/max+result, volumes...)

Next step is to compute the checksum and send other commands.
In my project, in need to tell the device to switch to Distance or Angle modes and capture the value.

I hope this will help you or any other developers.

Best regards.

2024-08-28_18h29_24

@PointerEvent
Copy link
Owner

Thank you for your interest! I'm glad to see this project is proving helpful to someone!

Your pull request looks quite good, but there is a bit of a formatting clash that makes it a bit harder to quickly identify the important parts. I'll try to get back to this later today. I appreciate you taking the time to flesh out the unfinished parts for others who may find themselves in the same boat in the future!

@Spomky Spomky force-pushed the features/better-data-support branch from 0267a93 to 75b0a7c Compare September 2, 2024 19:49
@Spomky
Copy link
Author

Spomky commented Sep 2, 2024

Hi @PointerEvent,

My mistake, my IDE changed the indentation of the HTML/CSS/JS and it looks crazy.
I restored most of the file and it should be much more clear.

Regards.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants