Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to 0.9.43 #27

Closed
wants to merge 12 commits into from
Closed

Update to 0.9.43 #27

wants to merge 12 commits into from

Conversation

JoshOrndorff
Copy link
Collaborator

Update Substrate dependency to polkadot-v0.9.43.

Copy link
Member

@pmikolajczyk41 pmikolajczyk41 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm but I don't know what is the problem with CI test :|

@pmikolajczyk41
Copy link
Member

oh, I see: error: unexpected argument '--ws-port' found - it must have changed recently

@@ -16,7 +16,6 @@ services:
- NODE_KEY_FILE=/data/$NODE01_ACCOUNT_ID/p2p_secret.txt
- PORT=30333
- RPC_PORT=9933
- WS_PORT=9944
Copy link
Contributor

@fbielejec fbielejec Jun 27, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is both the http and ws connectivity now on the same port in this Substarte version? If yes then:

  • make sure the first node (the one that exposes and binds ports to the host) uses whatever default ports the tools such as contracts-ui or polkadot/js wallet expect (this used to be a websocket on port 9944)
  • remove the port that is not needed from the exposed and from the host mapping section

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The default is now 9944 for both http and ws. Explained in paritytech/substrate#12663 (comment) and confirmed by my own testing.

node/Cargo.toml Outdated Show resolved Hide resolved
node/sha3pow/Cargo.toml Outdated Show resolved Hide resolved
@fbielejec
Copy link
Contributor

fbielejec commented Jun 27, 2023

lgtm but I don't know what is the problem with CI test :|

CI test fails because of the port change - the curl requests that ping the node should now be using the joint rpc/ws port 9944

Copy link
Contributor

@fbielejec fbielejec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice!

@JoshOrndorff
Copy link
Collaborator Author

Oops, forgot about this one. I've already updated it quite a bit more. I did break the ci big time though. I'll come back to that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants