Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CWL Feature Extraction workflow #8

Open
wants to merge 9 commits into
base: main
Choose a base branch
from

Conversation

hamshkhawar
Copy link
Member

This PR extracts utilizes 8 distinct plugins and extract features

Copy link
Member

@bengtl bengtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor spelling errors.
CI workflow definition needs to be updated, if non-owners are supposed to submit PRs.

README.md Outdated

#### 1. Install polus-plugins.

- clone a image-tools reporsitory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- clone a image-tools reporsitory
- clone a image-tools repository

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

README.md Outdated
- `pip install .`

#### 2. Install workflow-inference-compiler.
- clone a workflow-inference-compiler reporsitory
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
- clone a workflow-inference-compiler reporsitory
- clone a workflow-inference-compiler repository

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@bengtl
Copy link
Member

bengtl commented Mar 9, 2024

When running the workflow as described in the README, I get an error, see stacktrace below:
File "/Users/bengtljungquist/code/pr/image-workflows/cwl_workflows/main.py", line 53, in
app()
File "/Users/bengtljungquist/code/pr/image-workflows/cwl_workflows/main.py", line 47, in main
model.workflow()
File "/Users/bengtljungquist/code/pr/image-workflows/cwl_workflows/cwl_features_extraction.py", line 224, in workflow
ftl_plugin.connectivity = 1

File "/Users/bengtljungquist/code/pr/image-workflows/workflow-inference-compiler/src/wic/api/pythonapi.py", line 250, in setattr
self.inputs[index]._set_value(__value)
File "/Users/bengtljungquist/code/pr/image-workflows/workflow-inference-compiler/src/wic/api/pythonapi.py", line 94, in _set_value
raise TypeError(
TypeError: invalid attribute type for connectivity: got int, expected str

Copy link
Member

@bengtl bengtl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see comment in conversation regarding errors when running workflow, in addition to the spelling error.

@@ -0,0 +1,84 @@
# Common Workflow Language (CWL) Feature Extraction worflow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Common Workflow Language (CWL) Feature Extraction worflow
# Common Workflow Language (CWL) Feature Extraction workflow

@jfennick
Copy link
Contributor

jfennick commented Apr 1, 2024

@bengtl For security purposes, the CI has been configured to only run code from trusted users. Hamdah simply needs to change her github user to be a public member of the polusai organization.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants