Change VenueId to Option #1700
Merged
Change VenueId to Option #1700
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HenriqueNogara
changed the title
adamdossa
reviewed
Aug 13, 2024
| @@ -1962,13 +1973,15 @@ impl<T: Config> Module<T> { | |||
| fn ensure_venue_filtering( | |||
| tickers: &mut BTreeSet<AssetID>, | |||
| asset_id: AssetID, | |||
| venue_id: &VenueId, | |||
| venue_id: &Option<VenueId>, | |||
There was a problem hiding this comment.
Seems a bit odd to have it optional here, rather not calling this function when it is None?
adamdossa
approved these changes
Aug 13, 2024
HenriqueNogara
force-pushed
the
MESH-2030/optional-venue
branch
from
213bc47
to
aefa83a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
changelog
modified external API
Option<VenueId>: add_instruction, add_and_affirm_instruction, add_and_affirm_with_mediators, add_instruction_with_mediators;modified events
data migration