Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(hogql): placeholder expressions (part 1) #25091

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

mariusandra
Copy link
Collaborator

@mariusandra mariusandra commented Sep 19, 2024

Problem

Pulls out the first chunk from #25040

Changes

  • Convert placeholders from being LBRACE nestedIdentifier RBRACE to being LBRACE columnExpr RBRACE.
  • There should be zero functional changes. We will now be able to parse more complex syntax within placeholder tags, but we won't do anything with it. This is a separate PR mostly because releasing a new parser is its own dance.
  • Most places that use placeholders call the helper method/property node.field, so there was little to change.

How did you test this code?

Updated a lot of tests

@posthog-bot
Copy link
Contributor

It looks like the code of hogql-parser has changed since last push, but its version stayed the same at 1.0.40. 👀
Make sure to resolve this in hogql_parser/setup.py before merging!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants