Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Enhancement]: Link all environment checks to PNIDs, regardless of system type #100

Open
1 task done
jonbarrow opened this issue Jul 7, 2024 · 0 comments
Open
1 task done
Labels
approved The topic is approved by a developer enhancement An update to an existing part of the codebase

Comments

@jonbarrow
Copy link
Member

Checked Existing

  • I have checked the repository for duplicate issues.

What enhancement would you like to see?

Currently environment checks are done in 2 different ways depending on the system type:

  • 3DS - Checks the NEX account environment
  • Wii U - Checks the PNID environment

Since beta whitelisting is only automatically set at the PNID level, and it's not possible to reliably automate whitelisting/unwhitelisting 3DS consoles, we should instead require beta testers to link a beta-allowed PNID to their 3DS. Our servers should then:

  • Check for that linked PNID on the console
  • If a PNID is linked, use that for environment checks
  • If not, use the system/NEX account environment

This way we no longer need to worry about manually whitelisting 3DS users. We would also need to run a migration on the database to reset all (not banned) 3DS environments back to production, in order to catch any legacy users, enforce the PNID checks for new users, and catch any people left behind who had their 3DS account whitelisted but we never unwhitelisted it after they left beta

Any other details to share? (OPTIONAL)

No response

@jonbarrow jonbarrow added enhancement An update to an existing part of the codebase awaiting-approval Topic has not been approved or denied approved The topic is approved by a developer and removed awaiting-approval Topic has not been approved or denied labels Jul 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved The topic is approved by a developer enhancement An update to an existing part of the codebase
Projects
Status: Todo
Development

No branches or pull requests

1 participant