Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement email confirmation for parental controls (send_confirmation/pin/:email) #99

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from

Conversation

ItzSwirlz
Copy link

@ItzSwirlz ItzSwirlz commented Jun 29, 2024

Resolves #96

Changes:

  • Implements the send_confirmation/pin/:email route. Same method as resend_confirmation but gets the PNID from the database via email address instead off PID.

  • I have read and agreed to the Code of Conduct.

  • I have read and complied with the contributing guidelines.

  • What I'm implementing was an approved issue.

  • I have tested all of my changes.

Copy link
Member

@jonbarrow jonbarrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than this, looks good to me :+:

src/services/nnas/routes/support.ts Outdated Show resolved Hide resolved
@DaniElectra
Copy link
Member

This is not accurate to what the real endpoint does, this endpoint is used to send a "confirmation" email that the email has been registered on Parental Controls (see #27). It would make more sense to use sendEmailConfirmedEmail(), if anything.

@ItzSwirlz
Copy link
Author

This is not accurate to what the real endpoint does, this endpoint is used to send a "confirmation" email that the email has been registered on Parental Controls (see #27). It would make more sense to use sendEmailConfirmedEmail(), if anything.

Should I make a new function sendParentalControlsConfirmedEmail() for this purpose?

@ItzSwirlz
Copy link
Author

image

It works. 102-2534 is no longer shown when changing email address.

@ItzSwirlz ItzSwirlz changed the title support: implement send_confirmation/pin/:email Implement email confirmation for parental controls (send_confirmation/pin/:email) Jul 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants