Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Rewrite] Implement Matchmaking Rewrite #10

Draft
wants to merge 32 commits into
base: master
Choose a base branch
from

Conversation

AToska21
Copy link

@AToska21 AToska21 commented Sep 29, 2024

Resolves #9

Changes:

Implements the nex-protocols-common-go matchmaking rewrite.

@AToska21 AToska21 marked this pull request as draft September 29, 2024 13:21
@AToska21
Copy link
Author

NOTE: For this PR to function with the rewrite, some changes need to be applied to it.

  1. In matchmake-extension/database/find_matchmake_session_by_search_criteria.go, line 77, right after the for loop but before the if statement, add if i == 1 { continue; }.
  2. Replace all instances of ms.max_participants and ms.min_participants with g.max_participants and g.min_participants.

@AToska21 AToska21 marked this pull request as ready for review September 30, 2024 15:26
@AToska21 AToska21 marked this pull request as draft September 30, 2024 17:13
@AToska21
Copy link
Author

Reverted to draft due to Splatfest issues.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement]: Port to matchmaking rewrite
2 participants