dev: Set id on "UI select" of multiselect actors

This allows to give a label to the multiselect actors component. The "technical select" has the same id, suffixed by "-data".
Probesys · Jun 4, 2024 · d1cc409 · d1cc409
1 parent 6e4dd2f
commit d1cc409
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 4 deletions.
diff --git a/templates/tickets/filters/_multiselect_actors.html.twig b/templates/tickets/filters/_multiselect_actors.html.twig
@@ -6,7 +6,7 @@
 
 <div data-controller="multiselect-actors">
     <select
-        id="{{ id }}"
+        id="{{ id }}-data"
         name="{{ name }}"
         multiple
         data-multiselect-actors-target="data"
@@ -15,9 +15,9 @@
     >
         {% for user in users %}
             {% set isCurrentUser = user.id == app.user.id %}
-            {% set id = isCurrentUser ? '@me' : user.id %}
+            {% set userId = isCurrentUser ? '@me' : user.id %}
 
-            <option value="{{ isCurrentUser ? id : '#' ~ id }}" {{ id in selected ? 'selected' }}>
+            <option value="{{ isCurrentUser ? userId : '#' ~ userId }}" {{ userId in selected ? 'selected' }}>
                 {{ user.displayName }}
 
                 {% if user.id == app.user.id %}
@@ -29,6 +29,7 @@
 
     <div class="flow">
         <select
+            id="{{ id }}"
             data-multiselect-actors-target="select"
             data-action="multiselect-actors#select"
         >

diff --git a/templates/tickets/filters/edit_actors.html.twig b/templates/tickets/filters/edit_actors.html.twig
@@ -48,7 +48,7 @@
                     value="no"
                     {{ null in ticketFilter.filter('assignee') ? 'checked' }}
                     data-checkboxes-target="control"
-                    data-checkboxes-control="#filter-assignee"
+                    data-checkboxes-control="#filter-assignee-data"
                     data-action="checkboxes#switchDisabled"
                 />