Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make workflow config env var and add new NWN config file #100

Merged
merged 3 commits into from
Sep 13, 2024
Merged

make workflow config env var and add new NWN config file #100

merged 3 commits into from
Sep 13, 2024

Conversation

MarkTNO
Copy link
Contributor

@MarkTNO MarkTNO commented Sep 9, 2024

No description provided.

@MarkTNO MarkTNO linked an issue Sep 9, 2024 that may be closed by this pull request
Set workflow config file as env var #99
Closed
@MarkTNO MarkTNO self-assigned this Sep 9, 2024
@lfse-slafleur
Copy link
Contributor

Looks good! Good idea as well to use an env var.

@lfse-slafleur
Copy link
Contributor

Also, with #96 we introduced a changelog. Feel free to add this change here as well: https://github.com/Project-OMOTES/omotes-system/blob/main/CHANGELOG.md

@MarkTNO
Copy link
Contributor Author

MarkTNO commented Sep 13, 2024

changelog updated: 0f986c2

@MarkTNO MarkTNO merged commit cf5a261 into main Sep 13, 2024
1 check passed
@MarkTNO MarkTNO deleted the 99-set-workflow-config-file-as-env-var branch September 13, 2024 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lfse-slafleur lfse-slafleur lfse-slafleur approved these changes

@cwang39403 cwang39403 cwang39403 approved these changes

Assignees

@MarkTNO MarkTNO

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Set workflow config file as env var
3 participants
@MarkTNO @lfse-slafleur @cwang39403