Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Assets loader automatic retry #423

Merged
merged 5 commits into from
Oct 11, 2023

Conversation

Jomshir98
Copy link
Member

This PR implements automatic retry of loading resources that failed to load. It also moves in direction of being able to unload resources when we no longer need them, but that part is not yet implemented.
The actual loading is complicated, because PIXI has its own Texture cache, that however keeps textures that failed to load, too.

@Jomshir98 Jomshir98 added Type: Improvement Improvement of existing feature Component: Client Changes to client side of things Component: Graphics Changes to drawn graphics or assets labels Oct 9, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is from a Lead Developer.

@Jomshir98 Jomshir98 merged commit dc3a417 into master Oct 11, 2023
6 checks passed
@Jomshir98 Jomshir98 deleted the feature/assets-retry-loading branch October 11, 2023 19:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Client Changes to client side of things Component: Graphics Changes to drawn graphics or assets Type: Improvement Improvement of existing feature
Development

Successfully merging this pull request may close these issues.

2 participants