Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FIX] Fix alphamask change sometimes not trigerring redraw #425

Merged
merged 2 commits into from
Oct 15, 2023

Conversation

Jomshir98
Copy link
Member

Also avoids crashing when the mask is set to empty (which was why the original code was written in the way it was).
Adds a small fix to fix React's warning about duplicate key in wardrobe expressions, when two items have modules with same name.

@Jomshir98 Jomshir98 added Component: Graphics Changes to drawn graphics or assets Type: Fix Fixes something that isn't working labels Oct 15, 2023
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR is from a Lead Developer.

Copy link
Contributor

@ClaudiaMia ClaudiaMia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works!

@Jomshir98 Jomshir98 merged commit 05acdce into master Oct 15, 2023
9 checks passed
@Jomshir98 Jomshir98 deleted the fix/alphamask-update branch October 15, 2023 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component: Graphics Changes to drawn graphics or assets Type: Fix Fixes something that isn't working
Development

Successfully merging this pull request may close these issues.

2 participants