Windows Building: not detected as 64-bit when searching for _X64_ #473
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Vavassor
changed the title
Vavassor
changed the title
|
I'm merging this PR in along with some other PRs in a few. |
opdenkamp
added a commit
that referenced
this pull request
Mar 28, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This check does not find
_X64_inWindows.hon my computer (Visual Studio 2019). It does have_AMD64_, so I included a check for both.The error that failed the build was: 32-bit
time_twas set (with_USE_32BIT_TIME_T) even though_WIN64is defined.