Improve optimization in release profile #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. `lto = "thin"` + `codegen-units` is not a good idea, see rust-lang/rust#47745. `lto = true` and `codegen-units = 1` could potentially be better, though, although I doubt it'd matter too much. 2. `opt-level = 3` is already the default. 3. incremental has occasional strange bugs, best to leave it off
|
on the one hand, yeah, let's rev up those compile times, on the other hand, the compile times are easily the least painful part of auxmos |
MarkSuckerberg
pushed a commit
to MarkSuckerberg/auxmos
that referenced
this pull request
Sep 30, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
lto = "thin"+codegen-unitsis not a good idea, see codegen-units + ThinLTO is not as good as codegen-units = 1 rust-lang/rust#47745.lto = trueandcodegen-units = 1could potentially be better, though, although I doubt it'd matter too much, as the performance difference would likely only show in benchmarks, with little impact on actual use, so it's just more convenient to have the better linking speed with thin LTO.opt-level = 3is already the default.