Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove obsolete toml import from the test suite #1978

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

mgorny
Copy link
Contributor

@mgorny mgorny commented Oct 13, 2022

Remove the toml import that is used to determine whether to run pyproject.toml test. Firstly, toml has been replaced by tomli. Secondly, isort vendors tomli, so checking for its availability does not seem to make sense.

@staticdev
Copy link
Collaborator

@mgorny do you mind rebasing your PR?

Remove the `toml` import that is used to determine whether to run
`pyproject.toml` test.  Firstly, `toml` has been replaced by `tomli`.
Secondly, isort vendors `tomli`, so checking for its availability
does not seem to make sense.
@mgorny
Copy link
Contributor Author

mgorny commented Dec 21, 2022

Rebased.

@codecov
Copy link

codecov bot commented Dec 21, 2022

Codecov Report

Merging #1978 (45d6abd) into main (3020e0b) will not change coverage.
The diff coverage is n/a.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1978   +/-   ##
=======================================
  Coverage   98.80%   98.80%           
=======================================
  Files          38       38           
  Lines        3084     3084           
  Branches      745      745           
=======================================
  Hits         3047     3047           
  Misses         26       26           
  Partials       11       11           

@staticdev staticdev merged commit 3c2e2d0 into PyCQA:main Dec 21, 2022
@mgorny
Copy link
Contributor Author

mgorny commented Dec 22, 2022

Thank you!

@mgorny mgorny deleted the toml-test branch December 22, 2022 03:17
@staticdev
Copy link
Collaborator

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants