Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate black into our project #93

Closed
theSage21 opened this issue Apr 1, 2019 · 1 comment
Closed

Integrate black into our project #93

theSage21 opened this issue Apr 1, 2019 · 1 comment
Labels
easy easy to do good first issue Good for newcomers

Comments

@theSage21
Copy link
Member

Our project now has some logic code (like the ranking function). Since these functions/computations can be written over multiple lines, code formatting becomes an issue. Different people have different styles of writing the same code.

To make collaboration easier, we don't leave it up to the programmer to select a style. We enforce a style using Black.

To solve this issue, go through the README of the Black project and set it up with the git pre commit hook method as mentioned in this part of the README

@theSage21 theSage21 added good first issue Good for newcomers easy easy to do labels Apr 1, 2019
@rishabhKalakoti
Copy link
Contributor

rishabhKalakoti commented Apr 1, 2019

#94 : integrated black. (closed)
#95 : installed pre-commit, black

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
easy easy to do good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants