Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

integrated 'black' into project #94

Closed
wants to merge 21 commits into from
Closed

integrated 'black' into project #94

wants to merge 21 commits into from

Conversation

rishabhKalakoti
Copy link
Contributor

  • My title is a short description of what I am trying to do
  • I have mentioned all the issues I am fixing
  • Proposed changes

@rishabhKalakoti
Copy link
Contributor Author

had to merge the changes. idk why but all my commits appeared again.

@theSage21
Copy link
Member

I think you'll also have to install pre-commit in the pipenv? That should change the pipfile and the lock file

@theSage21
Copy link
Member

also, I think you did not create this branch from master?

@rishabhKalakoti
Copy link
Contributor Author

I ran pip install pre-commit in the pipenv shell. I did it again, but the pipfile did not change. I did install black outside too. Should I remove it first?

@theSage21
Copy link
Member

you'll need to run pipenv install

@rishabhKalakoti
Copy link
Contributor Author

I think i got it right this time :)

@theSage21
Copy link
Member

I think the approach is fine but you'll have to start a new PR. This current branch is polluted. Why don't you start from a clean branch.

  1. synchronize your master branch with pyjaipur master
  2. create a new branch
  3. pipenv --rm
  4. pipenv --deploy
  5. pipenv install pre-commit black
  6. commit and create PR

@rishabhKalakoti
Copy link
Contributor Author

Ok. I will close this one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants