Lookup cross compile config paths with runtime OUT_DIR vs compile time #4555
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change addresses a build failure I found when building Bazel rules for PyO3 (abrisco/rules_pyo3#14). Essentially, because Bazel compiles and runs build scripts in a sandbox at different locations, when environment variables that refer to a directory are compiled into build scripts, the directory embedded is to an old sandbox location that will not exist for any other action (running build scripts, compiling). This change resolves the build failure by using the
OUT_DIR
environment variable at runtime vs compile time to locate a cross compilation config.This change would have the side effect of these config files not being written into
pyo3-build-config
'sOUT_DIR
but theOUT_DIR
of whatever the crate was linked into. This is because when thepyo3-build-config
'srlib
is compiled, it'sOUT_DIR
will be embedded into it then, thus providing a locked absolute path for it's consumers.