Enable setting the module name of a class #477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for investigating the problem! |
This is relevant for pickling objects.
Codecov Report
@@ Coverage Diff @@
## master #477 +/- ##
==========================================
- Coverage 87.85% 87.85% -0.01%
==========================================
Files 65 65
Lines 3393 3416 +23
==========================================
+ Hits 2981 3001 +20
- Misses 412 415 +3
Continue to review full report at Codecov.
|
lycantropos
reviewed
May 9, 2019
| Some(module_name) => format!("{}.{}", module_name, T::NAME), | ||
| None => T::NAME.to_string(), | ||
| }; | ||
| let name = CString::new(name).expect("Module name/type name must not contain NUL byte"); |
Merged
konstin
approved these changes
May 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Didn't implement setting it automatically to avoid unexpected behavior. Pickling is possible but very awkward.
#100
Closes #474