Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfixing for optimist and pessimist cost data and fixing environment yaml #130

Merged
merged 3 commits into from
May 12, 2024

Conversation

toniseibold
Copy link
Contributor

@toniseibold toniseibold commented May 7, 2024

Optimist and Pessimist cost data did not work due to two minor bugs.
Maybe think about adding them to the CI check since running technology-data does not take too much time.
The environment.yaml was not working for the mock_snakemake.
Missing packages like pypsa and snakemake version > 8.0 necessary.

Closes # (if applicable).

Changes proposed in this Pull Request

  • bugfixing
  • updating environment.yaml

Checklist

  • Code changes are sufficiently documented; i.e. new functions contain docstrings and further explanations may be given in doc.
  • Data source for new technologies is cleary stated.
  • Newly introduced dependencies are added to environment.yaml (if applicable).
  • A note for the release notes doc/release_notes.rst of the upcoming release is included.
  • I consent to the release of this PR's code under the GPLv3 license.

@toniseibold toniseibold requested a review from lisazeyen May 7, 2024 11:44
@fneum fneum merged commit 1d3eb62 into master May 12, 2024
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants