Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add publish actions #270

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Add publish actions #270

wants to merge 2 commits into from

Conversation

multimeric
Copy link
Contributor

@multimeric multimeric commented Mar 7, 2023

@multimeric
Copy link
Contributor Author

I need some help adding the command we use for building wheels. python setup.py sdist_wheel doesn't seem to work.

@multimeric
Copy link
Contributor Author

I think this will need an update to: https://github.com/giovtorres/docker-centos7-slurm before it will work.

@tazend
Copy link
Member

tazend commented Mar 7, 2023

@multimeric

I've already worked on improving the docker-centos7-slurm container setup a bit and adding one for 22.05 - I'll try to get the changes up this weekend as a PR.

In regards to building: I wouldn't ship a prebuilt wheel right now. I would just upload the source distribution as tar.gz, by doing python setup.py sdist.

The User is expected to have a valid libslurm.so installed on the System where pyslurm should run (and potentially point the pyslurm installation to it if it is a custom slurm installation in a unusual path). When a user executes pip install pyslurm, the source will be cythonized and compiled on the Users specific system.

@multimeric
Copy link
Contributor Author

Great, thanks for the update. Agreed that we don't want to ship binary wheels. I for some reason thought there were source wheels but maybe there aren't, and it's just sdist that we want.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Enhancement] Update PyPi version and Sphinx docs?
2 participants