-
Notifications
You must be signed in to change notification settings - Fork 508
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Omnibus testing / platform portability fixes #3335
Conversation
- Silence all output generated when gathering solver availability / version information - Improve handling of version() not returning a tuple - Fix a bug where an exception raised when creating a solver caused an unhandled UnknownSolver error
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Small typo but otherwise it looks good.
@@ -238,6 +238,21 @@ def version(self, config=None): | |||
self._version_cache = (pth, version) | |||
return self._version_cache[1] | |||
|
|||
def has_linear_solver(self, linear_solver): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not thrilled with the repeat code here and in APPSI... But I get it.
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3335 +/- ##
==========================================
+ Coverage 88.52% 88.54% +0.01%
==========================================
Files 868 868
Lines 98436 98495 +59
==========================================
+ Hits 87144 87208 +64
+ Misses 11292 11287 -5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Fixes #3294.
Summary/Motivation:
This fixes a number of bugs / issues motivated by #3294 (which was building on a "partially complete" platform:
cp_optimizer
apparently generated an exceptionChanges proposed in this PR:
ipopt
interfaces to check for the availability of specific linear solversfreebsd
pyomo help -s
Legal Acknowledgement
By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution: