Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add context option to SuffixFinder #3348

Merged
merged 11 commits into from
Aug 15, 2024
Merged

Conversation

jsiirola
Copy link
Member

Fixes # .

Summary/Motivation:

PR #3295 highlighted a need that the SuffixFinder support a "context" option that defines the block (sub)hierarchy that it should use when searching for Suffixes.

Changes proposed in this PR:

  • Add context= parameter to SuffixFinder
  • Update scaling transform and NL writer to honor the model scope (context) when searching for Suffixes
  • Remove an unused private method that could lead to the incorrect context being assumed
  • Update tests

Legal Acknowledgement

By contributing to this software project, I have read the contribution guide and agree to the following terms and conditions for my contribution:

  1. I agree my contributions are submitted under the BSD license.
  2. I represent I am authorized to make the contributions and grant the license. If my employer has rights to intellectual property that includes these contributions, I represent that I have received permission to make contributions and grant the required license on behalf of that employer.

Copy link

codecov bot commented Aug 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.56%. Comparing base (123c465) to head (c810bc3).
Report is 12 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3348      +/-   ##
==========================================
- Coverage   88.56%   88.56%   -0.01%     
==========================================
  Files         877      877              
  Lines       99266    99276      +10     
==========================================
+ Hits        87919    87922       +3     
- Misses      11347    11354       +7     
Flag Coverage Δ
linux 86.09% <100.00%> (+<0.01%) ⬆️
osx 75.76% <100.00%> (+<0.01%) ⬆️
other 86.59% <100.00%> (-0.01%) ⬇️
win 83.92% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@blnicho blnicho merged commit 5206eee into Pyomo:main Aug 15, 2024
32 checks passed
@jsiirola jsiirola deleted the suffix-finder-context branch August 20, 2024 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

4 participants