Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix static typing #139

Merged
merged 1 commit into from
Dec 24, 2022
Merged

Fix static typing #139

merged 1 commit into from
Dec 24, 2022

Conversation

cffls
Copy link
Collaborator

@cffls cffls commented Dec 18, 2022

Fixed the following files:

pycardano/certificate.py
pycardano/coinselection.py
pycardano/key.py
pycardano/metadata.py
pycardano/plutus.py
pycardano/serialization.py
pycardano/transaction.py
pycardano/txbuilder.py
pycardano/utils.py
pycardano/witness.py

@codecov-commenter
Copy link

codecov-commenter commented Dec 18, 2022

Codecov Report

Merging #139 (6d98a01) into main (5e37db1) will increase coverage by 0.01%.
The diff coverage is 91.66%.

@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
+ Coverage   86.43%   86.44%   +0.01%     
==========================================
  Files          26       26              
  Lines        2734     2752      +18     
  Branches      649      651       +2     
==========================================
+ Hits         2363     2379      +16     
- Misses        279      281       +2     
  Partials       92       92              
Impacted Files Coverage Δ
pycardano/coinselection.py 91.73% <50.00%> (ø)
pycardano/txbuilder.py 91.53% <75.67%> (-0.32%) ⬇️
pycardano/certificate.py 92.59% <100.00%> (ø)
pycardano/cip/cip8.py 100.00% <100.00%> (ø)
pycardano/key.py 87.67% <100.00%> (+0.17%) ⬆️
pycardano/metadata.py 94.59% <100.00%> (ø)
pycardano/plutus.py 92.57% <100.00%> (+0.07%) ⬆️
pycardano/serialization.py 88.93% <100.00%> (+0.09%) ⬆️
pycardano/transaction.py 94.37% <100.00%> (+0.07%) ⬆️
pycardano/utils.py 94.82% <100.00%> (ø)
... and 1 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@cffls cffls force-pushed the static_typing_fix branch 2 times, most recently from 76c18c4 to d68fb5a Compare December 23, 2022 07:37
Fixed the following files:

pycardano/certificate.py
pycardano/cip/cip8.py
pycardano/coinselection.py
pycardano/key.py
pycardano/metadata.py
pycardano/plutus.py
pycardano/serialization.py
pycardano/transaction.py
pycardano/txbuilder.py
pycardano/utils.py
pycardano/witness.py
@cffls cffls merged commit fed5a70 into main Dec 24, 2022
@cffls cffls added the enhancement New feature or request label Feb 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants