Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix recursive deserialization of cbor bytes #194

Merged
merged 1 commit into from
Apr 4, 2023

Conversation

nielstron
Copy link
Contributor

Fixes #193

@codecov-commenter
Copy link

Codecov Report

Merging #194 (8ea663f) into main (68f26ee) will increase coverage by 0.19%.
The diff coverage is 100.00%.

📣 This organization is not using Codecov’s GitHub App Integration. We recommend you install it so Codecov can continue to function properly for your repositories. Learn more

@@            Coverage Diff             @@
##             main     #194      +/-   ##
==========================================
+ Coverage   85.45%   85.65%   +0.19%     
==========================================
  Files          26       26              
  Lines        2854     2844      -10     
  Branches      681      675       -6     
==========================================
- Hits         2439     2436       -3     
+ Misses        305      302       -3     
+ Partials      110      106       -4     
Impacted Files Coverage Δ
pycardano/serialization.py 86.90% <100.00%> (+2.17%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this bug!

@cffls cffls merged commit 2b1b98a into Python-Cardano:main Apr 4, 2023
@cffls cffls added the bug Something isn't working label Apr 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PyCardano does not correctly load nested PlutusData from cbor where the keys are unions of PlutusData
3 participants