Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kupo plutusv2 script from kupo #253

Merged
merged 5 commits into from
Jun 11, 2023

Conversation

nielstron
Copy link
Contributor

This should fix #252 but ideally there would be a test case for this

@codecov-commenter
Copy link

codecov-commenter commented Jun 8, 2023

Codecov Report

Merging #253 (9bfaf13) into main (94f8b96) will decrease coverage by 0.06%.
The diff coverage is 20.00%.

❗ Your organization is not using the GitHub App Integration. As a result you may experience degraded service beginning May 15th. Please install the Github App Integration for your organization. Read more.

@@            Coverage Diff             @@
##             main     #253      +/-   ##
==========================================
- Coverage   85.02%   84.97%   -0.06%     
==========================================
  Files          26       26              
  Lines        2979     2982       +3     
  Branches      714      714              
==========================================
+ Hits         2533     2534       +1     
- Misses        334      336       +2     
  Partials      112      112              
Impacted Files Coverage Δ
pycardano/backend/ogmios.py 59.84% <20.00%> (-0.31%) ⬇️

Copy link
Collaborator

@cffls cffls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix! Suggested one improvement in the code.

pycardano/backend/ogmios.py Show resolved Hide resolved
@cffls cffls added the bug Something isn't working label Jun 8, 2023
@cffls cffls merged commit bc02bd6 into Python-Cardano:main Jun 11, 2023
cffls pushed a commit to cffls/pycardano that referenced this pull request Jun 26, 2023
* Fix kupo plutusv2 script from kupo

* Formatting

* Apply try_fix_hash procedure if kupo is available

* Fix import
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reference input scripts are in wrong format
3 participants