Rename the reward redeemer tag to withdrawal #312
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ogmios 5 and blockfrost both refer to script redeemers that use the
withdrawal redeemer as "withdrawal:{index}". The only place where the
name of the redeemer tag is used is for evaluating the execution steps
in the transaction builder. Therefore I recommend renaming the redeemer
tag to the name used by other cardano tooling.
Note that in Ogmios 6, this name changes to "withdraw"
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #312 +/- ##
=======================================
Coverage 83.42% 83.42%
=======================================
Files 28 28
Lines 3415 3415
Branches 836 836
=======================================
Hits 2849 2849
Misses 416 416
Partials 150 150 ☔ View full report in Codecov by Sentry. |
cffls
approved these changes
Feb 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ogmios 5 and blockfrost both refer to script redeemers that use the withdrawal redeemer as "withdrawal:{index}". The only place where the name of the redeemer tag is used is for evaluating the execution steps in the transaction builder. Therefore I recommend renaming the redeemer tag to the name used by other cardano tooling.
Note that in Ogmios 6, this name changes to "withdraw".
This was previously part of #308