Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make vkey witnesses None when empty #377

Merged
merged 2 commits into from
Sep 22, 2024

Conversation

theeldermillenial
Copy link
Contributor

@theeldermillenial theeldermillenial commented Sep 22, 2024

This is a minor fix to vkey witnesses when empty in the transaction builder.

When building a transaction without signing keys, the empty vkey witnesses list gets encoded to an empty value in the witness. This seems to cause an issue for some wallets.

Preferably merged into the chang branch prior to #371

Copy link

codecov bot commented Sep 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.25%. Comparing base (043578d) to head (892d610).
Report is 1 commits behind head on chang.

Additional details and impacted files
@@            Coverage Diff             @@
##            chang     #377      +/-   ##
==========================================
+ Coverage   85.22%   85.25%   +0.03%     
==========================================
  Files          32       32              
  Lines        4209     4211       +2     
  Branches     1058     1059       +1     
==========================================
+ Hits         3587     3590       +3     
  Misses        435      435              
+ Partials      187      186       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@cffls cffls merged commit 46c453d into Python-Cardano:chang Sep 22, 2024
17 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants