Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pulling system root CAs to validate doesn't work against the released copy of safe #113

Closed
geofffranks opened this issue Oct 31, 2017 · 13 comments

Comments

@geofffranks
Copy link
Contributor

Targeting a Vault with a custom root CA that's added to my system keychain as a trusted root still requires a -k to skip ssl verification, when using the released copy of safe. If I build a fresh copy using golang 1.9, it works as expected.

Any chance we can update safe to build against v1.9, or determine why the released copy doesn't work as a hand-built copy?

@jhunt
Copy link
Contributor

jhunt commented Oct 31, 2017

Are you running Vault with a certificate signed by an authority you popped into your system chain? Trying to reproduce.

@geofffranks
Copy link
Contributor Author

geofffranks commented Oct 31, 2017 via email

@jhunt
Copy link
Contributor

jhunt commented Nov 17, 2017

Literally the only way around this seems to be building safe on darwin.

@jhunt
Copy link
Contributor

jhunt commented Nov 17, 2017

@geofffranks have you seen golang/go#18141 and golang/go#18203?

@geofffranks
Copy link
Contributor Author

Similar code and support is in spruce, and working for us, though spruce is built via Golang 1.9 on Linux. Perhaps that will work here too?

@jhunt
Copy link
Contributor

jhunt commented Nov 22, 2017

In that case try 0.5.0, since that should have been rebuilt with 1.9

@jhunt
Copy link
Contributor

jhunt commented Nov 22, 2017

Or maybe not. I'll have to talk to @thomasmmitchell since it seems per his commits to dockerfiles, we should be using 1.9

@jhunt
Copy link
Contributor

jhunt commented Nov 22, 2017

Ha! Turns out it's because the safe pipeline configuration was forcing 1.8.

I bumped it to 1.9 and it's running through the pipeline now. If all goes well, I'll cut 0.5.1 with macOS cert support this morning.

@thomasmitchell
Copy link
Contributor

Initially, the latest tag was stuck on, like... 1.6, so any pipelines made before then had to specify their go version explicitly. I bumped latest to 1.9, and should remember to bump it again when 1.10 comes out.

@jhunt
Copy link
Contributor

jhunt commented Nov 22, 2017

I still think I'll be pinning versions for all my go pipelines, so that I can control when I want to deal with the fall-out of having to upgrade go versions. Apparently 1.9 is a little more picky (if you can believe it) than previous versions of the compiler / toolchain.

@jhunt
Copy link
Contributor

jhunt commented Nov 22, 2017

@geofffranks try out 0.5.1, it seems to be working admirably in my test setup with a custom, mac-trusted CA and an issued cert.

@geofffranks
Copy link
Contributor Author

geofffranks commented Nov 22, 2017 via email

@jhunt jhunt closed this as completed Nov 22, 2017
@geofffranks
Copy link
Contributor Author

Yup, everything looks great here, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants